search

pwa-builder / pwabuilder-windows10

PWABuilder Windows 10 Platform
Other
16 stars 17 forks source link

add makePri in the platform creation step #14

Closed boyofgreen closed 8 years ago

boyofgreen commented 8 years ago

Mariano, This is what I want to do. Call the MakePri when we generate the project. I am not with my mac to test it out, but I believe this will work on the mac as well. It's just something we will do for everyone. When another process calls makePri it will just overwrite this one, which is fine. Can you test this and then we want to do a quick update for windows platform (we can just push out everything that have tested as v0.7).

mconverti commented 8 years ago

@boyofgreen I will start reviewing and testing this change today. I will update the windows10 platform once I'm done; probably tomorrow morning.

We should also deploy online-generator with this change, right?

boyofgreen commented 8 years ago

Yes, but cli is the priority, that is what the blog post talks about, then do cloud in case we run into issues there we don't want to let that slow down cli deploy