search

pwa-builder / pwabuilder-windows10

PWABuilder Windows 10 Platform
Other
16 stars 17 forks source link

there are some validation errors in the manifest.... there are none! #25

Closed wvmstr closed 6 years ago

wvmstr commented 7 years ago

Warnings (0)

Suggestions (0)

boyofgreen commented 7 years ago

Hey @wvmstr can you share the URL you are using? We'll take a look

wvmstr commented 7 years ago

www.billthis.comhttp://www.billthis.com BillThis - mobile business managementhttp://www.billthis.com/ Mobile business management for lawn mowers, farriers and equine veterinarians www.billthis.com

Robert

From: Jeff Burtoft notifications@github.com Sent: Tuesday, August 29, 2017 3:14 PM To: pwa-builder/manifoldjs-windows10 Cc: wvmstr; Mention Subject: Re: [pwa-builder/manifoldjs-windows10] there are some validation errors in the manifest.... there are none! (#25)

Hey @wvmstrhttps://github.com/wvmstr can you share the URL you are using? We'll take a look

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/pwa-builder/manifoldjs-windows10/issues/25#issuecomment-325766977, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AS3R0_lyLamsMqctCfBVLrrj14D2TfZVks5sdGMigaJpZM4PGVC_.

boyofgreen commented 7 years ago

Hi Robert, I ran that with the CLI and it gave me back errors. It looks like the first three images use a capital "X" instead of a lowercase "x" for the sizing. [error] general : Manifest validation ERROR - String does not match pattern: ^[0-9 x]+$ No enum match for: "128X128".(member: /icons/0/sizes). [error] general : Manifest validation ERROR - String does not match pattern: ^[0-9 x]+$ No enum match for: "48X48".(member: /icons/1/sizes). [error] general : Manifest validation ERROR - String does not match pattern: ^[0-9 x]+$ No enum match for: "16X16".(member: /icons/2/sizes).

I'll need to look into weather that is valid and we are identifying it incorrectly. Either way, we didn't return the errors and we should have, I'll add a task in to look at this. At any rate, if you go for the lowercase on the first three, looks like it all runs. Thanks, Jeff

wvmstr commented 7 years ago

Yup! It did run and I have submitted my PWA to the Windows App Store.