search

pwall567 / json-kotlin-schema

Kotlin implementation of JSON Schema (Draft 07)
MIT License
88 stars 12 forks source link

Any plans on implementing recursiveRef? #5

Open chatoooo opened 2 years ago

chatoooo commented 2 years ago

Hi, thanks for a great kotlin library.

I'm implementing tree structure in JSON so I need a recursiveRef. Do you have any plans to add the feature in a near future?

Thanks.

pwall567 commented 2 years ago

Hi - thanks for the feedback.

For some time now I've been working on an updated version of the project to meet the Draft 2020-12 version of the JSON Schema standard. That draft includes $dynamicRef which is similar to (but subtly different from) $recursiveRef. But that work is still several weeks away from being available for public exposure, so I'm currently looking into whether I can retro-fit some parts of the work into this project.

It's good to get feedback on what missing parts of the standard are most in demand, and I guess it's no surprise that $dynamicRef or $recursiveRef is high on the list. Give me a few days, and I'll report back here whether I think it's viable to add one or both of those keywords to the current project, without having to wait for the new version.

atuffreau-bcd commented 2 years ago

Hello, indeed thanks for the great library.

Do you have an update on meeting Draft 2020-12 version of the JSON Schema standard and $recursiveRef feature implementation?

pwall567 commented 2 years ago

Hi, and thanks for the compliment.

I apologise for not following up on my earlier comments - I did look into the idea of adding $recursiveRef or $dynamicRef to the current project, but I decided that It would involve a fair amount of work, and I preferred to put that effort into the new version.

The new version also includes Vocabularies, and that has necessitated a certain amount of structural change to the project. That work is progressing, but I can't promise to have anything available for public review for several weeks. Very sorry about that.

-Peter

mstrucka commented 1 year ago

Hi there, could you please provide a status update on this? :) I am getting a recursive $ref exception now and was just wondering, if the fix is near or I would have to opt for a different library... Thanks for the great work anyway!

pwall567 commented 1 year ago

Hi, thanks for the supportive comments.

I'm sorry, but I can't offer a timeline on the new version just yet. I suspect it won't be available before the end of the year. Unfortunately, other things (including my day job :smile: ) keep getting in the way.

Regards, Peter

milux commented 1 month ago

Just opened a PR that implements recursive $refs: https://github.com/pwall567/json-kotlin-schema/pull/20 Not exactly what this issue is about, but maybe helpful for building upon?