search

pwambach / angular-canvas-painter

Angular.js directive to paint on a canvas on desktop or touch devices
MIT License
116 stars 35 forks source link

Add 'reset' functionality, init() function #11

Closed z0d14c closed 9 years ago

z0d14c commented 9 years ago

I added a 'reset' functionality to this module. Using the scope.version functionality, instead of setting to a number (or decrementing), you set it to string value 'reset' and it resets the canvas, running the init() function (and resetting version to 0). The init() function is simply copy/pasting your code that initializes the canvas, it runs once in the linking function as well. You can simply mention merge this and mention the 'reset' functionality in your README. Thank you for all your hard work!

pwambach commented 9 years ago

Hey, thanks for your contributions. I have only my mobil phone with me for the next days so i have to take a closer look at your PR next week.

I have two questions for now: What do you want to achieve with the reset funtion?Why don't you just use infinite undo versions and set the version to 0 instead of 'reset'. In general parameter types should not be mixed (number or a string)

The second question is about your changes in general: Your changes include parts of the build file (the template cache stuff). If you do changes please use only the original source files.

Cheers Phil