search

pwambach / angular-canvas-painter

Angular.js directive to paint on a canvas on desktop or touch devices
MIT License
116 stars 35 forks source link

Trackpad/Mouse not working on touchscreen-notebooks #33

Open bersling opened 7 years ago

bersling commented 7 years ago

For users with a touchscreen-notebook the trackpad / mouse aren't working. I think this is because of line 229 of of https://github.com/pwambach/angular-canvas-painter/blob/master/js/pwCanvas.js because it uses if (!isTouch) {, meaning if a device has touch AND non-touch it won't work?

pwambach commented 7 years ago

Hey,

thanks for the hint. I didn't have this case in mind when I was building this project :) Sadly I don't have any time to dive back into the code. I guess you would have to normalize and handle both mouse and touch events equally and not decide between them.

PRs are welcome!

Cheers