pwang7 / rebook

96 stars 11 forks source link

Avoiding global variables #8

Open R-e-d-J opened 3 years ago

R-e-d-J commented 3 years ago

I'va take the time to read all your code and I see you're using a lot of global variable:

global strvarCmdArgs
global k2pdfopt_cmd_args
global strvarOutputFilePath
…

It's almost never a good idea. May be you can find a solution to avoid that and to be closer to the Bests Practices recommandations.