pwarocks / pwa.rocks

A selection of Progressive Web Apps
https://pwa.rocks/
Apache License 2.0
864 stars 415 forks source link

Icon not showing #327

Open nerdeveloper opened 6 years ago

nerdeveloper commented 6 years ago

`<a class="list__item app js-app" href="https://nerdeveloper.github.io/angular-pwa/" data-app="Coffee-app" data-tags="business shopping">

CoffeeApp

<style>
    [data-app='coffeeapp'] {
        color: #9400d3;
        background: currentColor url(apps/coffee.svg) 50% 50% / 50% auto no-repeat;
        }
</style>

` But after i run: npm run build npm run server

The app shows but the icon does not show

RobertJGabriel commented 6 years ago

app="Coffee-app" needs to match [data-app='coffeeapp'] .

Also if you want im making https://www.pwaawards.com/ and would love for you make a pr @nerdeveloper

nerdeveloper commented 6 years ago

Hello, @RobertJGabriel your link https://www.pwaawards.com/ seems to be broken. I think it's an SSL issue. I will love to submit a PR and thanks for the head up. I was able to fix it :smile: