search

pwatson100 / symbaroum

GNU General Public License v3.0
13 stars 19 forks source link

Inconsistency in chat report #234

Open THZ74 opened 3 years ago

THZ74 commented 3 years ago

Not sure if this is ment or if it is a sign of different people doing the coding of the different abilities.

If you use a power, weapon or ability. It should report it in the same way so you easily can see the results. (The brain always looks for patterns and it "hates" new ways, takes alot more attention if the same numbers are produced in a different way)

What I try to say is that mechanicly its not important, but for streamlining the UI it is.

Combat enhancement: (called CE later) Not that it calculates and rolls automaticly (this is ment) but what I wonder about is the line when CE is NOT active that reads:

Result margin : -7 But this Line is only written out on weapons or defenserolls, never (ok ..I havent checked all) abilities or powers.

I can see the usage of this number but maybe not taking up a full line and if it should be shown it should be shown in all instancies. (I feel this should be a mouseover function maybe?)

As it is now: CE off Weapon - Y Defense - n everything else - n

CE on Everything -n

Dice presentation: Difference between attacks and abilites

  1. Weapons spell out their damage like 1d8 + 1d6 [Beserker]
  2. what effects them (beserker)
  3. and what the sum are 4 .(and mouseover what the different dice rolled)

(this is the best solution ....and I think the latest iteration of it?)

Direct Damaging spells like Brimstone Cascade or Prios Burning glass

  1. Spell out damage
    • but not if something affect it (like Theurg (master)) 3 what the sum are 4 alot less info on rolls, a different mouseover effect

Area effect spells like Holy Aura

  1. Spell out damage
    • not by what it is affected by
    • not the sum
    • no mouseover (not even on what was rolled for temp corruption

Abilities like medicus

  1. Spells out effect as a dice -/2 not really like beserker above) but as a text above....Herbal Cure
  2. The sum is written out but in a slightly different pattern
  3. The "lesser mouseover

If I'm guessing , this is a HUGE pain in the ass to sort out (I have no coding knowledge) but its something to think about later in the "clean-up" phase. Because things should look the same. Not mainly because it looks nice but because that old brain function alot better if things behave like its used to.

Compare it to reading handwritten text vs printed text. (its the same problem for the brain who notices small changes and has to work extra)

Sorry for a long post. I hope you dont feel downlet by this. I love your work and I try to give constructive feedback not negative critisism (I try!)

Khaali-dev commented 3 years ago

This issue do come from slow coding that evolved over time. Some abilities were coded a long time ago (medicus) and weren't updated with newer dialog or chat format. We usually prefer to spend time on coding new functionalities that are really needed, than to spend this time in upgrading the old ones that works, even if theyr are not as pretty as what we do now. Those problems are slowly taken care of. You'll find a lot of improvements in the next release.

THZ74 commented 3 years ago

I would agree. Prioritize function over form at the moment.

I just wanted to point it out.

I hope it was obvious in my report that my intention was not to criticize but to reflect and that it wasn't a bug but something that would be important later for the "finish"

Respectfully Thz

Hämta Outlook för Androidhttps://aka.ms/AAb9ysg

From: Khaali @.> Sent: Sunday, August 1, 2021 11:42:07 PM To: pwatson100/symbaroum @.> Cc: THZ74 @.>; Author @.> Subject: Re: [pwatson100/symbaroum] Inconsistency in chat report (#234)

This issue do come from slow coding that evolved over time. Some abilities were coded a long time ago (medicus) and weren't updated with newer dialog or chat format. We usually prefer to spend time on coding new functionalities that are really needed, than to spend this time in upgrading the old ones that works, even if theyr are not as pretty as what we do now. Those problems are slowly taken care of. You'll find a lot of improvements in the next release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/pwatson100/symbaroum/issues/234#issuecomment-890591199, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVAEPOMU7XWEJP4I3YLTUOTT2W5S7ANCNFSM5BE43ZJA.