pwatson100 / symbaroum

GNU General Public License v3.0
13 stars 19 forks source link

Move saveCombatRoll and saveAttributeRoll to client settings #670

Open psdao1102 opened 2 months ago

psdao1102 commented 2 months ago

Hello,

I would like to suggest that saveCombatRoll and saveAttributeRoll get moved to client settings as it would be nice for it to be selected as a pc, but not necissarily as a GM who has to move between many different characters.

my understanding is that we would have to change

 game.settings.register('symbaroum', 'saveCombatRoll', {
    name: 'SYMBAROUM.OPTIONAL_SAVECOMBATROLL',
    hint: 'SYMBAROUM.OPTIONAL_SAVECOMBATROLL_HINT',
    scope: 'world',
    type: Boolean,
    default: false,
    config: true
  });
  game.settings.register('symbaroum', 'saveAttributeRoll', {
    name: 'SYMBAROUM.OPTIONAL_SAVEATTRIBUTEROLL',
    hint: 'SYMBAROUM.OPTIONAL_SAVEATTRIBUTEROLL_HINT',
    scope: 'world',
    type: Boolean,
    default: false,
    config: true
  });

to be client instead of world.

Thank you!

bithir commented 1 month ago

I'm going to park this one for Foundry VTT v13. It will introduce a new scope, 'user', which would suite these settings much better than 'client' would.

See API improvements on https://foundryvtt.com/releases/13.332