pwittchen / ReactiveNetwork

Android library listening network connection state and Internet connectivity with RxJava Observables

http://pwittchen.github.io/ReactiveNetwork/docs/RxJava2.x/

Apache License 2.0

2.53k stars 276 forks source link

replacing default protocol HTTP with HTTPS in WalledGardenInternetObs… #376

Closed Kisty closed 4 years ago

Kisty commented 4 years ago

This PR introduces the following update from RxJava2.x branch to fix #323

codecov-io commented 4 years ago

Codecov Report

Merging #376 into RxJava1.x will decrease coverage by 0.65%. The diff coverage is 75%.

@@             Coverage Diff              @@
##           RxJava1.x    #376      +/-   ##
============================================
- Coverage      75.86%   75.2%   -0.66%     
============================================
  Files             10      10              
  Lines            348     359      +11     
  Branches          33      34       +1     
============================================
+ Hits             264     270       +6     
- Misses            56      61       +5     
  Partials          28      28

Impacted Files	Coverage Δ
...trategy/WalledGardenInternetObservingStrategy.java	`84.44% <75%> (-9.68%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29cc69d...253f104. Read the comment docs.

Kisty commented 4 years ago

Hmm, not sure what to do about this.

Kisty commented 4 years ago

Squished!

Kisty commented 4 years ago

Morning! Are you able to cook up a release for RxJava 1.x, please? Trying to use JitPack to make a custom build but having trouble, though it looks like it's working now. A proper release would be better.

Incidentally, would it be better to use the RxJava2 implementation? Can RxJava 1 & 2 coexist in same app?

I also tried adding as a submodule but can't due to rootProject.ext calls which the ext fields aren't at my root. I could put them manually, but that would be hacky. Unless you've solved this for RxJava 2.x branch, this might be worth looking in to.

pwittchen commented 4 years ago

Hi,

I'll try to release new version today in the evening. It's my side project and I'm not able to do it earlier.

Can RxJava 1 & 2 coexist in same app?

Theoretically they can, but it's not good idea because you can easily mix imports and classes from different releases/packages what can cause errors. You can also use interop libraries to convert RxJava1 code into RxJava2 code dynamically. Maybe you can keep both of them during the migration phase, but it shouldn't be long-term solution.

Kisty commented 4 years ago

Thanks, man. Appreciate that and thanks for maintaining this great project!

pwittchen commented 4 years ago

PR merged. Update will be available in version 0.13.0 -> #377

Kisty commented 4 years ago

Thanks a lot, man!