search

pwittchen / ReactiveNetwork

Android library listening network connection state and Internet connectivity with RxJava Observables
http://pwittchen.github.io/ReactiveNetwork/docs/RxJava2.x/
Apache License 2.0
2.53k stars 276 forks source link

connection speed #431

Open eslam2010011 opened 4 years ago

eslam2010011 commented 4 years ago

this library be from Facebook, can it be combined with your library to measure internet speed? Thank you

https://github.com/facebookarchive/network-connection-class

pwittchen commented 4 years ago

It can be combined with any library. It's developer choice how to perform an integration. In the case of the linked library, everything depends on what you want to achieve.

eslam2010011 commented 4 years ago

Can you add it now, thank you

pwittchen commented 4 years ago

I don't want to add too many dependencies to this library. If you want to combine network-connection-class and ReactiveNetwork, then it should be done in your application. Moreover, I don't know what do you want to achieve, so even if I'd like to add new functionality to my library, I don't know your expectations.

eslam2010011 commented 4 years ago

This helps a lot in making decisions, such as whether the internet is weak, it switches to offline mode, and when the internet is strong, it switches to online mode, not just knowledge, there is internet or not

pwittchen commented 4 years ago

I know, but this library has single responsibility. I don't want to put too many things in it. You can combine these two projects in your app by yourself if you need to.