Allow to pass custom instance of Gson object

[danieldisu]

Although the JsonConverter interface exists, in my use case I would only require to pass my GSON instance with my CustomAdapters set, so this constructor would greatly help this instead of having to create my own JsonConverter with exactly the same methods than the GsonConverter but with my custom GSON instance.

[codecov-io]

Codecov Report

Merging #123 into RxJava2.x will decrease coverage by 1.91%. The diff coverage is 50%.

@@              Coverage Diff              @@
##           RxJava2.x     #123      +/-   ##
=============================================
- Coverage      99.33%   97.41%   -1.92%     
=============================================
  Files              5        5              
  Lines            151      155       +4     
  Branches          11       11              
=============================================
+ Hits             150      151       +1     
- Misses             0        3       +3     
  Partials           1        1

Impacted Files	Coverage Δ
...b/pwittchen/prefser/library/rx2/GsonConverter.java	62.5% <50%> (-37.5%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 009a008...d49a46e. Read the comment docs.

[pwittchen]

Hi,

Thanks for the PR. I'll take a look on that soon.

Regards

25.09.2017 9:49 AM "Codecov" notifications@github.com napisał(a):

Codecov https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=h1 Report

Merging #123 https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=desc into RxJava2.x https://codecov.io/gh/pwittchen/prefser/commit/009a008554f3e4d5946e822d1edf0f67880473eb?src=pr&el=desc will decrease coverage by 1.91%. The diff coverage is 50%.

[image: Impacted file tree graph] https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=tree

@@ Coverage Diff @@## RxJava2.x #123 +/- ## =============================================- Coverage 99.33% 97.41% -1.92%

Files 5 5 Lines 151 155 +4 Branches 11 11 =============================================+ Hits 150 151 +1 - Misses 0 3 +3 Partials 1 1

Impacted Files https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=tree Coverage Δ ...b/pwittchen/prefser/library/rx2/GsonConverter.java https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=tree#diff-bGlicmFyeS9zcmMvbWFpbi9qYXZhL2NvbS9naXRodWIvcHdpdHRjaGVuL3ByZWZzZXIvbGlicmFyeS9yeDIvR3NvbkNvbnZlcnRlci5qYXZh 62.5% <50%> (-37.5%) ⬇️

Continue to review full report at Codecov https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=continue.

Legend - Click here to learn more https://docs.codecov.io/docs/codecov-delta Δ = absolute (impact), ø = not affected, ? = missing data Powered by Codecov https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=footer. Last update 009a008...d49a46e https://codecov.io/gh/pwittchen/prefser/pull/123?src=pr&el=lastupdated. Read the comment docs https://docs.codecov.io/docs/pull-request-comments .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pwittchen/prefser/pull/123#issuecomment-331803286, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqcF_8kWi94-UtDgh_MG3bFYh6cL0vZks5sl1r8gaJpZM4PiUcW .