search

pwittchen / prefser

Wrapper for Android SharedPreferences with object serialization and RxJava Observables
Apache License 2.0
228 stars 26 forks source link

#159 Fix OnSharedPreferenceChangeListener being GCed after some time #160

Closed ubuntudroid closed 5 years ago

ubuntudroid commented 5 years ago

Fixes #159

pwittchen commented 5 years ago

Thanks for creating this PR! I'll review it soon.

codecov-io commented 5 years ago

Codecov Report

Merging #160 into RxJava2.x will increase coverage by 0.16%. The diff coverage is 93.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##           RxJava2.x     #160      +/-   ##
=============================================
+ Coverage      97.38%   97.54%   +0.16%     
=============================================
  Files              5        5              
  Lines            153      163      +10     
  Branches          11       11              
=============================================
+ Hits             149      159      +10     
  Misses             3        3              
  Partials           1        1
Impacted Files Coverage Δ
.../github/pwittchen/prefser/library/rx2/Prefser.java 98.88% <93.33%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4d3040...edee876. Read the comment docs.

ubuntudroid commented 5 years ago

@pwittchen Here you go. 🤓

pwittchen commented 5 years ago

Merged. Update will be available in the next release.