search

pwlin / cordova-plugin-file-opener2

A File Opener Plugin for Cordova
MIT License
314 stars 584 forks source link

Specify the static version of the Android framework to avoid build error #198

Closed ivanosire closed 5 years ago

ivanosire commented 6 years ago

Building android platform this error appear: "ERROR: In FontFamilyFont, unable to find attribute android:fontVariationSettings
ERROR: In FontFamilyFont, unable to find attribute android:ttcIndex"

With the sign + the android framework used is the new and latest version (28.0.0) but seems incompatible now.

I have fixed writing static version of framework 27.1.0

ghost commented 6 years ago

Noticed the same issue. Any chance to merge that one please?

davidgv88 commented 6 years ago

Please Merge!

zcoffin86 commented 6 years ago

Potentially this implementation would be more agreeable, since it will default to not changing the value yet allows you to explicitly set it in the config. https://github.com/Compeat/cordova-plugin-file-opener2/commit/514dd7d5f60627b9cbe5f01c8beea4a23df1e2b2

shnist commented 5 years ago

hi @ivanosire, thank you for your contribution to this project. We have implemented a solution as per https://github.com/Compeat/cordova-plugin-file-opener2/commit/514dd7d5f60627b9cbe5f01c8beea4a23df1e2b2. This is a more flexible solution and is becoming a fairly standardised pattern across the cordova plugin ecosystem. You can now specify the android support version at installation time: cordova plugin add cordova-plugin-file-opener2 --variable ANDROID_SUPPORT_VERSION={required version} . This is available in the new 2.1.0 version. This should help resolve your issue and as such we'll be closing this PR.