New Commit 2019 05 12 - Githubissues

pwlin / cordova-plugin-file-opener2

A File Opener Plugin for Cordova

MIT License

314 stars 587 forks source link

New Commit 2019 05 12 #258

Closed syaafiqi closed 5 years ago

syaafiqi commented 5 years ago

Add new functions:

appVersion -- to check installed package version
appVersionCode -- to check installed package versionCode

i edit the java files but it's not kinda working. can you make this official build, i think the concept of function is there. just cant properly build the plugin.

Thanks

shnist commented 5 years ago

@pwlin what's your thoughts on these 2 new methods?

pwlin commented 5 years ago

hi @shnist some how I have missed responding to this. I am really sorry. Please do not wait 24 days for a response. Your judgment here is much respected and appreciated!

pwlin commented 5 years ago

Hi @syaafiqi thanks for your PR. Your functions are neat and helpful, I think you should create a simple Cordova Plugin out of it. Maybe an utility plugin which returns app's stats/info? :)

syaafiqi commented 5 years ago

Hi @syaafiqi thanks for your PR. Your functions are neat and helpful, I think you should create a simple Cordova Plugin out of it. Maybe an utility plugin which returns app's stats/info? :)

Yeah i think plugin that return app's stats/info could be a thing. Maybe i'll consider to make it. Thank you for ur response and suggestion :)