search

pwlin / cordova-plugin-file-opener2

A File Opener Plugin for Cordova
MIT License
314 stars 584 forks source link

Values in Android Manifest get removed. version 2.2.0 #264

Closed newuser44 closed 4 years ago

newuser44 commented 5 years ago

Expected Behaviour

After building, would expect file to be open.
This problem seems to stem from another plugin either firebase or cordova-android-support-gradle-release.
Android is added and plugins are pulling in.
Manifest looks normal, but more has this line is in the Manifest file.

But then when I build. This provider is removed.
Then File opener does not work.

Actual Behaviour

After a build Manifest File is missing a provider. Can not open a file.

Reproduce Scenario (including but not limited to)

See above.

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

Not sure this matters. Android 8. Samsung S7.

Cordova CLI info

cordova info

Here is the output: Collecting Data...

Node version: v6.16.0

Cordova version: 7.0.1

Config.xml file:

<?xml version='1.0' encoding='utf-8'?>

App Name App Name

Plugins:

cordova-android-support-gradle-release,cordova-plugin-android-fingerprint-auth,cordova-plugin-device,cordova-plugin-file,cordova-plugin-file-opener2,cordova-plugin-firebase,cordova-plugin-geolocation,cordova-plugin-ios-keychain,cordova-plugin-nativestorage,cordova-plugin-network-information,cordova-plugin-splashscreen,cordova-plugin-statusbar,cordova-plugin-touch-id,cordova-plugin-whitelist,cordova-plugin-x-socialsharing,es6-promise-plugin,ionic-plugin-keyboard

Error retrieving Android platform information: Android SDK is not set up properly. Make sure that the Android SDK 'tools' and 'platform-tools' directories are in the PATH variable.

Error: android: Command failed with exit code ENOENT

Plugin version

cordova plugin version | grep cordova-plugin-file-opener2

Here is the output:

cordova-plugin-file-opener2 2.2.0 "File Opener2"

shnist commented 4 years ago

hi @newuser44, thanks for raising this issue. Is this related to the other issue that you raised earlier? https://github.com/pwlin/cordova-plugin-file-opener2/issues/259

newuser44 commented 4 years ago

Yes it looks like it is. It seems to be related to the cordova-plugin-firebase plugin. When adding android back in, some order of plugins to be installed is followed. Seems like cordova-plugin-firebase is one of the last and overrides some values in android manifest. I haven't tested this theory.

shnist commented 4 years ago

@newuser44 closing this ticket as a duplicate of #215. It seems to be the same issue. The plugin makes changes to the Android manifest xml file and if your config.xml also attempts to make changes then there is a clash and this error occurs. Looking into a fix now.