pwlin / cordova-plugin-file-opener2

A File Opener Plugin for Cordova
MIT License
314 stars 583 forks source link

fix(#329): removed 'REQUEST_INSTALL_PACKAGES' android permission #330

Closed rpanadero closed 1 year ago

rpanadero commented 1 year ago

Fixes issue #329.

If your application needs this permission because of some requirement, you must add this permission from your application config.xml as the plugin's README says.

https://github.com/pwlin/cordova-plugin-file-opener2#android-apk-installation-limitation

RobYed commented 1 year ago

It would be great to see this merged and released, as the Play Store deadline which disallows releasing apps with this permission is coming closer (29th September 2022).

AntuV commented 1 year ago

Bump, date's coming closer

123toto commented 1 year ago

Hi is it possible to merge and release this pull request, since Playstore deadline is already outdated

rajat-biztech commented 1 year ago

@pwlin Any update on this. This is urgent for use to get our app approved on google play store

TheAnkurPanchani commented 1 year ago

https://www.npmjs.com/package/@theankur/cordova-plugin-file-opener2

123toto commented 1 year ago

it's not a worry about fork, it's more than I'm using it with @awesome-cordova-plugins that wrapped this plugin

jsBiztech commented 1 year ago

@pwlin Any update on this. Our app is rejected because of this permission. We want this on high priority .

TheAnkurPanchani commented 1 year ago

@123toto : In that case, following PR might help. https://github.com/danielsogl/awesome-cordova-plugins/pull/4353

minusonebyytwelve commented 1 year ago

Hey Guys, I did the same but the app still got rejected. I have 2 plugins using this permission. this plugin and Cordova plugin intent. I removed this line from both the plugins, this permission was not even in AndroidManifest,xml file, still, it is showing this error. Can anyone help?

chiraganand commented 1 year ago

Hey Guys, I did the same but the app still got rejected. I have 2 plugins using this permission. this plugin and Cordova plugin intent. I removed this line from both the plugins, this permission was not even in AndroidManifest,xml file, still, it is showing this error. Can anyone help?

Did you check by opening up the APK (unzip XXX.apk) and looking at AndroidManifest.xml? You should also check this when the bundle is uploaded on Play Store. The bundle information shows the permissions the app is asking for.

minusonebyytwelve commented 1 year ago

Hey Guys, I did the same but the app still got rejected. I have 2 plugins using this permission. this plugin and Cordova plugin intent. I removed this line from both the plugins, this permission was not even in AndroidManifest,xml file, still, it is showing this error. Can anyone help?

Did you check by opening up the APK (unzip XXX.apk) and looking at AndroidManifest.xml? You should also check this when the bundle is uploaded on Play Store. The bundle information shows the permissions the app is asking for.

Thanks, Chirag, The APK was fine. The issue was I had to add a new build that does not have 'REQUEST_INSTALL_PACKAGES' in all tracks. I was uploading a new build in production and internal testing but the Open testing track still had the old build with this permission. The email I received did not include the build number or the track so the confusion happened.

chiraganand commented 1 year ago

I was uploading a new build in production and internal testing but the Open testing track still had the old build with this permission. The email I received did not include the build number or the track so the confusion happened.

Yes, I also faced this. Apparently, none of the binaries in any active track should have the old code.

RubenPera commented 1 year ago

Hey @pwlin could you please merge this pull request?

thomeijken commented 1 year ago

Bump! One of my apps just got removed because of this permission.

shnist commented 1 year ago

this has been fixed in the latest release