search

pwlin / cordova-plugin-file-opener2

A File Opener Plugin for Cordova
MIT License
314 stars 583 forks source link

Combined changes to fix FileProvider.java (AndroidX) and remove REQUEST_INSTALL_PACKAGES permission #336

Closed brospars closed 1 year ago

brospars commented 1 year ago

For my own app I had to fix both FileProvider and remove REQUEST_INSTALL_PACKAGES to be compliant with Google new policy.

Fix #326 and #329. Same as #333, #332, #330, #318 and #312 but combined.

ShahinBelim commented 1 year ago

Guys, do we expect this PR to be merged? Our app is getting rejected because of this permission issue.

brospars commented 1 year ago

I have contacted the owner and other major contributors. Let's hope they let someonelse take over. 🤞

shnist commented 1 year ago

@brospars thanks for getting in touch. Can i just double check what changes in behaviour users of the plugin can expect if remove REQUEST_INSTALL_PACKAGES is removed? I'd like to understand if this is a breaking change and if so whether the package needs to be bumped to V4. If you think it would help to update the readme as well please do so.

brospars commented 1 year ago

Hi @shnist thanks for the quick response. Yes removing REQUEST_INSTALL_PACKAGES can be breaking if you used this plugin to install .apk. But this could be easily fixed by adding this permission in your main app AndroidManifest.xml.

Many apps are being rejected because of this, since now you need to justify the usage of this permission. Plus, I don't think plugins should presumed what permission the user will need but instead let the developer set their own permission.

shnist commented 1 year ago

hi @brospars - I have created a new release that includes both fixes outlined in this PR (with some extra tidy up work related to the migration of androidX). If you could test it out and feedback I would be grateful.

brospars commented 1 year ago

Seems good to me.

shnist commented 1 year ago

Great thanks @brospars . I will close this PR.