pwmckenna / node-travis-encrypt

node module to encrypt environment variables for travis-ci
npmjs.org/package/travis-encrypt
46 stars 12 forks source link

Prefer JS encrypt? #11

Open Gaff opened 9 years ago

Gaff commented 9 years ago

Have you considered using jsencrypt instead of ursa? Not a killer thing but it's much kinder to windows users who otherwise need to install python to get ursa ro run.

Here's the npm link: https://www.npmjs.com/package/jsencrypt

I had a quick look but I'm basically a node n00b and completely clueless on how to hack about with this stuff :p. However if I get the time / inclination I'll give it another go.

letmaik commented 9 years ago

+1 just tried to install it and it failed because it requires Python 2, and I have 3

rstacruz commented 9 years ago

you're right, ursa doesn't even work with node.js 4.0

rstacruz commented 9 years ago

there's a fix, i've published it as @rstacruz/travis-encrypt for now.

https://www.npmjs.com/package/%40rstacruz%2Ftravis-encrypt

ArtskydJ commented 8 years ago

I had to install node-gyp (which is pretty friendly now with windows-build-tools), and OpenSSL.

Maybe the solution is to use https://github.com/roblabla/ursa-purejs. This module would barely have to change. But it does have node-rsa as a dependency.

@pwmckenna would you be willing to accept a PR to use ursa-purejs instead of ursa?

rstacruz commented 8 years ago

I'm a collaborator. I'll allow it. :)