search

pwmckenna / node-travis-encrypt

node module to encrypt environment variables for travis-ci
npmjs.org/package/travis-encrypt
46 stars 12 forks source link

change ursa to node-rsa #12

Closed rstacruz closed 8 years ago

rstacruz commented 9 years ago

ursa is not compatible with node.js 4.0. See #11.

this hasn't been tested too thoroughly.

rstacruz commented 9 years ago

oh and it looks like travis is set up in this repo but there's no way to test it.. haha

rstacruz commented 9 years ago

@pwmckenna I can merge this, but I can't push it to npm by the way.

MoOx commented 9 years ago

+1 for this.

pwmckenna commented 8 years ago

merging in master (which has the travis sudo update) seems to have sorted out the build. I'm happy to merge this in if someone has tested the whole cycle of something encrypted with it and can vouch for it. @rstacruz thanks for the work on this!

pwmckenna commented 8 years ago

@rstacruz added you as an owner on npm, so feel free to merge/publish :)

marco-c commented 8 years ago

Note that we've used the library behind node-rsa (http://www-cs-students.stanford.edu/~tjw/jsbn/) in our project (https://github.com/mozilla/pluotsorbet) and it did suffer from correctness problems.

To overcome the correctness problems, we've had to use it in a non-standard way.

See https://github.com/pwmckenna/node-travis-encrypt/pull/17#issuecomment-149911411.

rexxars commented 8 years ago

I'm a bit skeptical to merging this, based on experiences from @marco-c - especially since I'm not sure how to properly write tests to uncover any problems. Until we get more requests for a better experience on windows, I think we should put this on hold. Closing.