search

pwmt / zathura

Document viewer
https://pwmt.org/projects/zathura
zlib License
1.87k stars 128 forks source link

Text selection is wrong after rotation #391

Closed sebastinas closed 2 months ago

sebastinas commented 1 year ago

On GitLab by @oliverlew on Apr 5, 2023, 17:29

Screencast_20230405_232227

Apart from the selection's wrong reaction to mouse dragging (probably just forgot to transform the coordinates), there are also issues of highlights not cleared properly sometimes.

Pinging @rahulaggarwal965, who added this text selection feature.

sebastinas commented 1 year ago

On GitLab by @rahulaggarwal965 on Apr 9, 2023, 11:17

Would you be able to also send a screenshot/video of the issues with the highlights not clearing? Is that just a problem with the rotation or does that occur in the normal case as well?

sebastinas commented 1 year ago

On GitLab by @oliverlew on Jun 19, 2023, 09:31

Oh, @rahulaggarwal965, so sorry, I have no idea why I haven't received a notification email for this. And I forgot to check this issue after since.

For your question, the issue of hightlights clearing appears under rotation only. Here is a screen recording:

Screencast_20230619_152040

sebastinas commented 9 months ago

mentioned in commit 1e9d9718fef1ecc6c0b2b342b9c1f02fb6872223