"warning: Failed to parse color string" with zathura 0.5.3 #434

Closed sebastinas closed 2 months ago

On GitLab by @Antiz on Dec 9, 2023, 19:06

Hello,

Zathura v0.5.3 (built with these build/packaging instructions on an Arch Linux system) produces the following warning message at each usage:

warning: Failed to parse color string 'rgba(100%,%84,0%,0.9)'.

(org.pwmt.zathura:7247): Gtk-CRITICAL **: 18:19:17.954: gtk_event_controller_set_propagation_phase: assertion 'GTK_IS_EVENT_CONTROLLER (controller)' failed

Zathura v0.5.2 does not produce such warning.
Here is the output of zathura --version (thus including the warning):

$ zathura --version
warning: Failed to parse color string 'rgba(100%,%84,0%,0.9)'.

(org.pwmt.zathura:7247): Gtk-CRITICAL **: 18:19:17.954: gtk_event_controller_set_propagation_phase: assertion 'GTK_IS_EVENT_CONTROLLER (controller)' failed
zathura 0.5.3
girara 0.4.1 (runtime: 0.4.1)
(plugin) pdf-poppler (0.3.2) (/usr/lib/zathura/libpdf-poppler.so)

Build logs for the produced zathura v0.5.3 package are available here.
The resulted built packages for zathura v0.5.3 and girara v0.4.1 are also available here and can be installed locally on an Arch based system for testing purposes if needed.

I remain available if you any additional information are required! :)

On GitLab by @Antiz on Dec 9, 2023, 19:32

Cross-linking the related issue I opened on Arch side: https://gitlab.archlinux.org/archlinux/packaging/packages/zathura/-/issues/1

mentioned in commit 8d2ca4b1a2821b931b4a4d69d733fdc248fc773e

@Antiz 0.5.4 has been released with the fix. I was wondering what's the need for the xvfb-run patch. Does Arch have xvfb-run that is different from the other distributions?

On GitLab by @Antiz on Dec 10, 2023, 12:31

@sebastinas Alright, thanks a lot for your quick actions!

Regarding the xvfb-run patch, the -a option has been deprecated in favor of the -d/--auto-display some time ago (see this comment and this GitHub issue for instance). Depending on which distribution (or which version of it) you use in your build environment, you may still have a xvfb-run version compatible with the -a option but since Arch's using latest upstream release of xvfb-run (due to its rolling release model), the -a option is not a thing anymore there, causing the following error during xvfb-run checks:

/usr/bin/xvfb-run: line 171: kill: (25939) - No such process

Replacing the -a argument by -d (which is what the patch does) solved the issue. If your build environment is compliant with the -d option already, I can make a MR on your side for that if you want me to :)

Arch's xvfb-run is based off of Fedora's which is froked from Debian's but the change with -a/-d seems to be local to Fedora/Arch only. Looks like this was never contributed back to Debian.

On GitLab by @Antiz on Dec 10, 2023, 13:44

Actually it seems like it comes from a (apparently Fedora's) xvfb fork that Arch seems based on. The Fedora's xvfb forked version is distributed locally within the Arch package, while the rest is indeed based off of Debian's sources.

So it seems it is not Arch specific but rather depends on distros' choice to base their xvfb package on Debian's or Fedora's script/version. From what I see from this thread, it seems like Red Hat and NixOS (among others) are also based on this fork while Ubuntu's is not (explaining the different behavior between your build env, which is using Ubuntu if I'm not mistaken, and mine).

Anyway, that's clearly a distro/downstream specific choice/matter. I'll just keep this patch on Arch side and develop why it is needed with the above, to make it clearer.

The next release will auto-detect whether -a or -d is required.

On GitLab by @Antiz on Dec 10, 2023, 13:47

Alright then, thanks a lot!
I'll drop this patch at next release then :wink:

pwmt / zathura

"warning: Failed to parse color string" with zathura 0.5.3 #434