Selection fixes - [merged]

[sebastinas]

On GitLab by @marcoe on Jul 9, 2023, 24:17

---

Merges selection-fixes -> develop

This is a preparatory MR for more feature work on selections e.g. bringing back rectangle selection. The following shortcomings of the current implementation are being addressed:

• Text selection could not be cleared after zooming, rotating reliably.
• Text could not be selected if the document was rotated (#347).
• Occasional one pixel wide lines persisted after selection was cleared.

fixes #347

[sebastinas]

Sorry for the delay. Would it be possible to split the fixes into a separate MR? Thanks

[sebastinas]

On GitLab by @marcoe on Sep 12, 2023, 16:19

---

added 5 commits

• 0b183eae - Simplify mouse selection
• 858673f7 - Cleanup: use locally declared page whenever possible
• d46f9625 - Fix selection not working on a rotated page
• be1a0d5a - Bring back rectangle selection in a form of a highlighter
• 496c31ea - Update docs

Compare with previous version

[sebastinas]

On GitLab by @marcoe on Sep 12, 2023, 16:44

---

I have changed this MR to include only fixes and preparatory work. It contains 3 commits, Gitlab in this little log says its 5 because I hastened myself and force pushed with the feature commits, but quickly retracted. Apparently the log did not update.

[sebastinas]

mentioned in commit 1e9d9718fef1ecc6c0b2b342b9c1f02fb6872223