pwnall / chromeview

Proof of concept Android WebView implementation based on Chromium code
1.69k stars 434 forks source link

Limitation should be noted! #41

Open sonusingh opened 10 years ago

sonusingh commented 10 years ago

It would be great if it was made clear on the main page that this will not work on Android 3.x or below!

It would have saved me a lot of time trying to figure out why the application never started properly and crashed.

ghost commented 10 years ago

Eclipse throws a compile error if you set minSdkVersion < Library's minSdkVersion.

sonusingh commented 10 years ago

i don't get any compiler errors, but the following code doesn't seem to work:

package com.example.test;

import android.os.Bundle; import android.app.Activity; import android.view.Menu;

import us.costan.chrome.ChromeView;

public class MainActivity extends Activity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    ChromeView.initialize(this);
    ChromeView chromeView = (ChromeView)findViewById(R.id.chromeView1);
    chromeView.loadUrl("http://www.google.com");
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    // Inflate the menu; this adds items to the action bar if it is

present. getMenuInflater().inflate(R.menu.main, menu); return true; }

}

On Mon, Dec 2, 2013 at 7:34 AM, HackerK notifications@github.com wrote:

Eclipse throws a compile error if you set minSdkVersion < Library's minSdkVersion.

— Reply to this email directly or view it on GitHubhttps://github.com/pwnall/chromeview/issues/41#issuecomment-29599179 .

ghost commented 10 years ago

Ah.. I use eclipse kepler and ADT 22.3.

And You MUST

ChromeView.initialize(this);

at application, not activity.

kashban commented 10 years ago

It's also not working for Android 4.4 and above. This should be noted too, as it cost me quite some time finding this.