pwncollege / dojo

Infrastructure powering the pwn.college dojo
https://pwn.college
BSD 2-Clause "Simplified" License
279 stars 87 forks source link

ZFS "Dataset does not exist" #386

Open ConnorNelson opened 5 months ago

ConnorNelson commented 5 months ago

This error hard locks a container. Other ZFS issues (so far) can be resolved by just hitting "Start" again. This one cannot.

Error response from daemon: container a049ad5cd863c54ccea009b3ea7be5c89e4c74f8aa6d3e8a5ab51fc7202814c2: driver "zfs" failed to remove root filesystem: exit status 1: "/usr/sbin/zfs destroy -r data/docker/3085584be1a23f433b4b1ae828485d3d90818d3e0e473d5d9627d7f71858458a" => cannot open 'data/docker/3085584be1a23f433b4b1ae828485d3d90818d3e0e473d5d9627d7f71858458a': dataset does not exist

In this case we need to zfs create data/docker/3085584be1a23f433b4b1ae828485d3d90818d3e0e473d5d9627d7f71858458a, so that Docker can feel good about deleting it.

Probably someone should talk to moby/moby.

zardus commented 5 months ago

This is something that we could do in the handler when we hit that error... Should we do it?

adamdoupe commented 5 months ago

This does not inspire confidence about our move to zfs.