pwnieexpress / blue_hydra

Blue Hydra
Other
837 stars 109 forks source link

If test-discovery fails to run, it's not apparent #115

Open steev opened 6 years ago

steev commented 6 years ago

I'm not sure the best way to do this, so I figured I'd open an issue to discuss.

If you run blue_hydra, but test-discovery fails to run (due to missing path for bluezutils), it will sit there as if it's searching - but looks as if it's just not finding anything.

I noticed we do pay attention to if there's an error in test-discovery running, but we don't do anything but log it; wouldn't it be better to die if there is an issue?

ZeroChaos- commented 6 years ago

It fails sometimes, and then starts working again. So no, dying would be bad. But maybe after it fails a few times in a row it makes sense to die. There are a few examples of catching and recovering from bluez failures in there, should be easy enough to add a generic case.

On Oct 24, 2017 00:16, "Steev Klimaszewski" notifications@github.com wrote:

I'm not sure the best way to do this, so I figured I'd open an issue to discuss.

If you run blue_hydra, but test-discovery fails to run (due to missing path for bluezutils), it will sit there as if it's searching - but looks as if it's just not finding anything.

I noticed we do pay attention to if there's an error in test-discovery running, but we don't do anything but log it; wouldn't it be better to die if there is an issue?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pwnieexpress/blue_hydra/issues/115, or mute the thread https://github.com/notifications/unsubscribe-auth/ABl--cAH3ob-OaaTVbtHVcu9A5O1QTq4ks5svWSkgaJpZM4QD0lT .

-- This e-mail and any attachments are for the sole use of the intended recipients(s) and may be confidential. Use of any Pwnie Express product signifies your agreement to the Rapid Focus Security Terms of Service https://www.pwnieexpress.com/terms-of-service and is subject to export controls under the U.S. Commerce Department’s Export Administration Regulations (“EAR”).