search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.42k stars 136 forks source link

feature/popup on issue hover #129

Closed pwntester closed 3 years ago

pwntester commented 3 years ago

Addresses #99

pwntester commented 3 years ago

Please don't get my review wrong. My intention was not to bash your work. You did an excellent job in adding this feature! They are (hopefully) constructive feedback on how you can improve in writing code related to exact examples. Many of the comments can be applied to multiple parts of your changes, though I have not put them multiple times (ofc). So I hope you read them, process them and then agree or disagree with it. In this project I have no hard feelings about the code of others. So feel free to ignore any comment. My best wishes are that we can learn something from each over and get better over time for any kind of development.

Im totally open to learn (growth mindset) so dont worry to comment/suggest any part of the code. That why I added you as a reviewer after all :smile:

pwntester commented 3 years ago

Also, thank you very much for taking the time to contribute, review and share you knowledge!

weilbith commented 3 years ago

Im totally open to learn (growth mindset)

Great attitude! :muscle:

Nice that you applied these changes to quick, iterating over your code to improve it. Looking forward to get this merged and use it. :hugs: