pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.42k stars 136 forks source link

change prompt_prefixes to prompt_titles #151

Closed rudotriton closed 3 years ago

rudotriton commented 3 years ago

Describe what this PR does / why we need it

This change brings about some consistency with with all the other Telescope's prompts, by setting the prompt title instead of the prefix. This also preserves users' custom prompt prefixes in case they have set any.

Does this pull request fix one issue?

closes #150

Describe how to verify it

Running any of the Octo's commands should now show the "action" as a prompt title instead of the prefix.

What Octo's prompts look like:

Screen Shot 2021-05-30

What Telescope's inbuilt prompts look like (with a user-set prompt_prefix):

Screen Shot 2021-05-30

What Octo's prompts would be changed to (with a user-set prompt_prefix):

Screen Shot 2021-05-30
pwntester commented 3 years ago

Cool, thanks!