search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.42k stars 136 forks source link

Feature Request: Open PR from Octo #169

Closed hahuang65 closed 3 years ago

hahuang65 commented 3 years ago

Open PR from Octo

Type: feature request

Describe what happened (or what feature you want)

Would be nice to be able to directly open a PR from Octo, be able to set the title, description, assign labels, projects, milestones, assignees, and reviewers.

pwntester commented 3 years ago

@hahuang65 I have a basic implementation where the user needs to specify the target repo and base and head branches. That requires that the user has already pushed his branch to the target repo or fork.

Does that work for you? The reason Im asking is that gh allows to create a new fork, push the branch there and then create the PR. I think that is a little too much for octo.nvim, but can try to implement if that's what people expects

hahuang65 commented 3 years ago

I'm actually not sure what the general use-case should be, or if there even is one.

When I use gh, I usually just do gh pr create --web --fill and it just creates a PR against the repo I'm in, with the defaults for branches as the current branch I'm on, into the trunk branch master or main or whatever is designated.

So for me personally, the use-case would be to use the current repo, with the current branch, targeting a PR into the designated mainline branch.

pwntester commented 3 years ago

Implemented in #178 @hahuang65 can you test it please?

hahuang65 commented 3 years ago

Thanks for the diligence, will test and write comments in the PR.

pwntester commented 3 years ago

Closing since implementation was merged

shivanthzen commented 2 years ago

I found this feature while exploring. This should be added to the README !!!

pwntester commented 2 years ago

Thanks for the heads up, just added it