Fix PR checkout from telescope list

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor

MIT License

2.42k stars 136 forks source link

Fix PR checkout from telescope list #183

Closed morgsmccauley closed 3 years ago

morgsmccauley commented 3 years ago

Describe what this PR does / why we need it

Checking out PR from Octo pr list does not work. The telescope entry is being interpreted incorrectly, selection.value is the PR number rather than a table.

Does this pull request fix one issue?

Describe how you did it

Use the correct number when attempting to checkout a PR

Describe how to verify it

Tested the change locally

Special notes for reviews

pwntester commented 3 years ago

Thanks a lot, I will be changing this function to reuse commands.checkout_pr which does not depend on gh and is a lo faster. Please test it if you can

pwntester commented 3 years ago

I implemented that change on https://github.com/pwntester/octo.nvim/pull/184 but it is now in master