search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.34k stars 127 forks source link

Feature request: Select current branch for PR #194

Closed abatilo closed 2 years ago

abatilo commented 3 years ago

Right now, it seems that I need to be able to search for the PR that I want to open in order to review it. I work on a monorepo where there's perpetually 40+ PRs on the repository. What I normally do is I'll gh pr status to look for the reviews that are assigned to me and then I'll gh pr checkout those PRs.

If I wanted to incorporate my workflow to use Octo, now I'd still have to open up vim, Octo pr list, and then I'd have to remember how I can match against the PR output from gh pr status.

I'd love it if I could just simply Octo review start and to have Octo recognize which branch I have checked out currently and to start a review on that branch.

pwntester commented 3 years ago

The problem is the missing GitHub info (eg: PR number). Would it be enough to expose gh pr status as an Octo command that shows the info on a menu?

abatilo commented 3 years ago

Would it be possible to use the information provided by:

gh pr status --json number --jq ".currentBranch.number"

?

currentBranch is only available if your current checked out branch is actually open in a PR.

pwntester commented 2 years ago

Hi! Sorry, for the late response. I just implemented this on #212 Can you please check it out and let me know if it works as you expected?