Feature Request: Integrate Octo with Diffview

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor

MIT License

2.34k stars 127 forks source link

Feature Request: Integrate Octo with Diffview #196

Closed mrswats closed 2 years ago

mrswats commented 3 years ago

I am a big fan of the DiffView plugin, and I was wondering if it would be possible to integrate it with Octo pr diff instead of the default differ if it is installed. I understand that maybe in that case adding comments or other line actions might not be available, but I think it's something worth looking into as the default differ is not very flexible.

Many thanks for this plugin, I just started using, and I absolutely love it. Having GitHub on NeoVim is great!

pwntester commented 3 years ago

Thanks for the kind words and the suggestion. I actually borrowed most of diffview code for the review panel (as credited in the README). So you get a very similar layout when doing Octo review start or Octo review resume. You can always discard the review with Octo review discard if you dont need it. If this workflow does not work for you. We could show the same panels/layouts on Octo pr diffview but:

not creating a review
not showing comments/threads
disabling new comments
not allowing review submission

mrswats commented 3 years ago

Oh, I missed this review subcommand! Okay, I will take a look first.

Nonetheless, one thing I like to do in my terminal is to run gh pr diff then pipe it through some differ like delta. I would have thought that using diffview here would be somewhat similar to "pipe" the resulting diff to diffview.

Thanks for the answer!