search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

Allow user to use custom submit_win mappings #270

Closed jarviliam closed 2 years ago

jarviliam commented 2 years ago

Issue Description

Type: bug report

Describe what happened (or what feature you want)

I have my Tmux configured to use <C-a> for the prefix key which conflicts with the approve action in the review submission window. When I attempted to use a different mapping it didn't appear to change. I'm assuming this is a bug (not intentional) as it seems like the user's keymaps are not used for submit_win and review_diff here : https://github.com/pwntester/octo.nvim/blob/5e461b944fbf9b6207cf06102ca09fd7778854f7/lua/octo/config.lua#L163-L168

Describe what you expected to happen

I expected to be able to use my own submit_win mappings.

Also, thanks for the plugin 🙏 . It's very useful!