Closed akinsho closed 2 years ago
Thanks for reporting @akinsho, I was internally using git
, I changed to gh
in https://github.com/pwntester/octo.nvim/commit/3a75706ec3e915ed11579961886afeed662565a9 can you check if it fixes the issue for you?
@pwntester thanks for the quick fix, that seems to have resolved the issue 👍🏿. As a very minor point I noticed that it doesn't give feedback when you actually make the change e.g. a notification (via vim.notify) like it does when it errors (this a complete tangent though as the main issued is solved)
Thanks!, Just improved the message shown after checkout, it should now show whatever branch is active after the checkout
Issue Description
Type: bug report or feature request
Describe what happened (or what feature you want)
Hi @pwntester, so I previously reported this issue in #146, and you kindly fixed it. I've noticed however that this behaviour has regressed and when trying to check out the PR for a fork I get a path not found error. I think it is maybe failing to fetch the PR correctly, however this consistently works using the
gh
cli which I thought this plugin actually used under the hood.Describe what you expected to happen
When I run
Octo pr list
and select the PR from a contributor to one of my repos, it should checkout that PR, so I can review itHow to reproduce it (as minimally and precisely as possible)
This is specific to me as an example
Octo pr list
Octo pr checkout
Tell us your environment
Anything else we need to know?