search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

Migration to Teal with GitLab Support #282

Open l0nax opened 2 years ago

l0nax commented 2 years ago

Issue Description

Type: "feature request"

Describe what happened (or what feature you want)

Since I really love this plugin but mostly work with GitLab, I decided to start the migration to Teal allowing us to easily implement gitlab (or any other Host provider).

See #138

Since the code base is not small anymore, I did not migrate the whole project to Teal, instead, only the parts which are relevant for the implementation are migrated/ refactored.

Currently, only GitLab issues are implemented.

pwntester commented 2 years ago

Hi @l0nax thanks for the PR. Can you elaborate on why gitlab provider cannot be supported in plain lua? Im ok adding support for GitLab or other providers but Im not considering migrating @

brendalf commented 2 years ago

Hello there. I agree with @pwntester, the gitlab support should use the glab tool as backend, which is a non official gitlab cli, akin to gh cli. In fairness, I started looking at this because I use gitlab in my company and Octo is awesome. I'd love to work in that integration, WDYT @pwntester? Can I open a MR with some raw work to kick off some discussions?

pwntester commented 2 years ago

Sure, that sounds great!

sunzoje commented 2 years ago

Glab is now officially adopted by GitLab. https://github.com/profclems/glab/issues/983

brendalf commented 1 year ago

Hi there. Sorry for taking so long. I will open the MR this weekend.

l0nax commented 1 year ago

@sunzoje I already converted roughly about 70% of the code base to lua. I will push the changes this weekend.

Daemoen commented 1 year ago

Any update on this ?