search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

Gitlab with teal #283

Closed l0nax closed 1 year ago

l0nax commented 2 years ago

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

I've removed/ moved all the content from lua/ to src/ and did not commit the new content of lua/ otherwise it would be difficult to review what has changed (in the lua code).

If merged onto master the code has to be "compiled" and put into the lua/ directory.

The code has to be "compiled" back to lua since we do not want to break the caching mechanism (slowing down the startup of Nvim):

~$ rm -rf lua/*
~$ tl build
~$ rsync -zarv --include="*/" --include="*.lua" --exclude="*" "src/" "lua/"
farbodsz commented 1 year ago

Hey @pwntester - are there any plans to merge this in the near future? Would be great to have GitLab support in Octo!

pwntester commented 1 year ago

Im sorry, but any GitLab support should be added in pure lua since Im not considering moving the project to Teal at this point

farbodsz commented 1 year ago

That's fair. @l0nax , do you think you'll work on a Lua-only version for this feature? If not, I'm happy to give it a go

brendalf commented 1 year ago

Hi folks, I'm almost there. I will open the MR this weekend.

globin commented 1 year ago

Any news on this?