search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

Reply to comments from pull request view #288

Closed axkirillov closed 2 years ago

axkirillov commented 2 years ago

Issue Description

feature request

Describe what happened (or what feature you want)

It seems that commend add only works in the context of a review. As a creator of a PR I want to be able to reply to comments from my reviewers without "starting" a review. Currently if I press <space>ca or run :Octo comment add in the PR overview tab I get this message

Start a new review to reply to a thread

Describe what you expected to happen

pressing <space>ca in pr comment thread should open a comment buffer

How to reproduce it (as minimally and precisely as possible)

  1. Open a PR from :Octo pr list
  2. press <space>ca in a comment thread or run :Octo comment add
  3. see this message Start a new review to reply to a thread

Tell us your environment

MacOS Monterey 12.3 Neovim 0.7 octo.nvim latest (installed with vim-plug)

Anything else we need to know?

pwntester commented 2 years ago

Thanks for reporting, this was figured out by @ldelossa here. Will try to implement it soon

axkirillov commented 2 years ago

@pwntester awesome, thank you 😃

pwntester commented 2 years ago

@axkirillov Just implemented this as part of #294 would you mind testing it?

axkirillov commented 2 years ago

@pwntester Hi, sorry for late reply, I would have loved to test it, but unfortunately I updated octo today and since then it became unusable for me. Sadly I don't have enough time to debug and create issues so I have to fall back to web ui for now. Nevertheless, big thank you for your work.

pwntester commented 2 years ago

@axkirillov thanks for letting me know, no need to debug though, if you could please send me error messassge or screenshot and I will look into it

alex-popov-tech commented 2 years ago

@pwntester im willing to test, but from PR i did not understand how to use it...is it <space>ca having cursor on line with THREAD COMMENT?

pwntester commented 2 years ago

Thanks @alex-popov-tech yep, please cursor on THREAD COMMENT line or any or the comments on the thread and press <space>ca or :Octo comment add

alex-popov-tech commented 2 years ago

@pwntester it works! but for some reason it duplicates comment, ie i put one comment in buffer, then do :w to send it, then i do Octo pr reload and then i see 2 same comments :(

pwntester commented 2 years ago

@alex-popov-tech thats weird, I cannot reproduce it. Can you please send a video so I can see the exact line where you run the add comment command?

alex-popov-tech commented 2 years ago

Hey @pwntester , sorry for bothering, it seems it was my internet issue, it's working now as a charm ❤️❤️❤️