Closed axkirillov closed 2 years ago
Thanks for reporting, this was figured out by @ldelossa here. Will try to implement it soon
@pwntester awesome, thank you 😃
@axkirillov Just implemented this as part of #294 would you mind testing it?
@pwntester Hi, sorry for late reply, I would have loved to test it, but unfortunately I updated octo today and since then it became unusable for me. Sadly I don't have enough time to debug and create issues so I have to fall back to web ui for now. Nevertheless, big thank you for your work.
@axkirillov thanks for letting me know, no need to debug though, if you could please send me error messassge or screenshot and I will look into it
@pwntester im willing to test, but from PR i did not understand how to use it...is it <space>ca
having cursor on line with THREAD COMMENT
?
Thanks @alex-popov-tech yep, please cursor on THREAD COMMENT
line or any or the comments on the thread and press <space>ca
or :Octo comment add
@pwntester it works! but for some reason it duplicates comment, ie i put one comment in buffer, then do :w
to send it, then i do Octo pr reload
and then i see 2 same comments :(
@alex-popov-tech thats weird, I cannot reproduce it. Can you please send a video so I can see the exact line where you run the add comment command?
Hey @pwntester , sorry for bothering, it seems it was my internet issue, it's working now as a charm ❤️❤️❤️
Issue Description
feature request
Describe what happened (or what feature you want)
It seems that
commend add
only works in the context of a review. As a creator of a PR I want to be able to reply to comments from my reviewers without "starting" a review. Currently if I press<space>ca
or run:Octo comment add
in the PR overview tab I get this messageStart a new review to reply to a thread
Describe what you expected to happen
pressing
<space>ca
in pr comment thread should open a comment bufferHow to reproduce it (as minimally and precisely as possible)
<space>ca
in a comment thread or run:Octo comment add
Start a new review to reply to a thread
Tell us your environment
MacOS Monterey 12.3 Neovim 0.7 octo.nvim latest (installed with vim-plug)
Anything else we need to know?