pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

allow web devicons to be an optional dependency #297

Closed quentin-fox closed 2 years ago

quentin-fox commented 2 years ago

Describe what this PR does / why we need it

In the README, it looks like the file_picker.use_icons field could be set to false to make the web devicons an optional dependency, but the line that reads from this config property was commented out.

Does this pull request fix one issue?

NONE

Describe how you did it

Just uncommented the relevant line out.

Describe how to verify it

Uninstall the nvim-web-devicons package from the nvim runtime, and open the file picker. It should still work without a lua require stack trace appearing in the messages pane, provided that the file_picker.use_icons config property is set to false.

Special notes for reviews

pwntester commented 2 years ago

Thanks for the PR!