search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

Trying to create a PR using `octo create pr [draft]` succeeds partially with error #299

Closed shivanthzen closed 2 years ago

shivanthzen commented 2 years ago

BUG

In a git repo, try :Octo create pr draft Navigate the prompts , (bse master, Confirmation etc ) The PR is successfully created but while opening the description window, it fails with the following error

Error

Describe what you expected to happen Able to write and submit PR description

How to reproduce it (as minimally and precisely as possible) Try to create a PR with Octo pr create in an org project Tell us your environment MacOS

NVIM v0.8.0-dev+352-g19e80738e Build type: Release LuaJIT 2.1.0-beta3

Anything else we need to know? Don't think so!

pwntester commented 2 years ago

Hi,

Thanks for reporting the issue, I was not able to reproduce it, but added some null checks to try to prevent the error. Can you please try https://github.com/pwntester/octo.nvim/pull/300 ?

shivanthzen commented 2 years ago

Hey, saw the comment now. The latest master works as expected after the merge. Thanks.