search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

[feature] make 'Octo comment add' work for visual #303

Closed alex-popov-tech closed 2 years ago

alex-popov-tech commented 2 years ago

Issue Description

Type: feature request

Describe what feature you want

Please make 'Octo comment add' work on visual, it will be more consise and understandable than now using OctoAddReviewComment. Also relevant for suggestions.

Anything else we need to know?

Related to https://github.com/pwntester/octo.nvim/discussions/301

pwntester commented 2 years ago

Turns out there was a bug introduced when I changed the mappings to use "vim.keymap.set". I took the opportunity to improve the support for multiline comments and thread buffer responsivness. Please check out latest version and let me know if it works for you now (no need to use OctoAddReview commands, in fact I removed them)

alex-popov-tech commented 2 years ago

its working now like a charm, thank you <3