Closed DexterShepherd closed 2 years ago
Had the same issue
found the following by printing the threads[1]
table:
... ["originalStartLine"] = vim.NIL, ["line"] = 13,["originalLine"] = 13,["startLine"] = 13, ...
So for some comments originalStartLine
is vim.NIL
Currently fixed it locally by overriding the line
value
-- octo.nvim/lua/octo/reviews/thread-panel.lua
function M.create_thread_buffer(threads, repo, number, side, path)
local current_review = require("octo.reviews").get_current_review()
if not vim.startswith(path, "/") then
path = "/" .. path
end
local line = threads[1].originalStartLine
if line == vim.NIL then
line = threads[1].startLine
end
Hello, thanks for the great plugin!
Issue Description
Type: bug report
Describe what happened (or what feature you want)
I see this error when moving the cursor over an inline comment in a PR.
Describe what you expected to happen
To be able to view PR comments
How to reproduce it (as minimally and precisely as possible)
:Octo review start
I've reprod this with multiple pull requests / repos.
Tell us your environment
macos 12.4 nvim 0.7.2
Anything else we need to know?
Minimal init.vim