search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.33k stars 125 forks source link

Update vim.fn.trim for nightly neovim #322

Closed aaronhallaert closed 2 years ago

aaronhallaert commented 2 years ago

Describe what this PR does / why we need it

I updated my neovim to the nightly branch and broke octo.nvim when opening a PR. Apparently vim.fn.trim is renamed to vim.trim.

Describe how you did it

Replace all occurences of vim.fn.trim to vim.trim

Describe how to verify it

Open a PR with octo.nvim

Special notes for reviews

I'm not sure if this PR should be merged for now since this is a fix for a nightly version of Neovim.

pwntester commented 2 years ago

Thanks for the PR, and sorry for the late response (still on vacations). Im sorry I cannot merge the PR as is since it would break older versions. Since I still dont have access to a laptop, could you make a trim function in the utils module that calls either vim.fn.trim or vim.trim depending on which one exists?

pwntester commented 2 years ago

Thank you @aaronhallaert !