pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.28k stars 125 forks source link

`Octo pr create` uses wrong branch #334

Closed LoipesMas closed 1 year ago

LoipesMas commented 1 year ago

Issue Description

Type: bug report

Describe what happened (or what feature you want)

Context: remote origin loipesmas/foo, fork of upstream, ssh remote upstream someone/foo, http default default_remote setting checked out on branch that is tracking on origin

I wanted to create a PR from origin to upstream I did :Octo pr create It said that branch does not exist on remote, even though it was pushed to origin (Then I selected to create the branch and it tried to create it on origin, but failed because my public key has a passphrase (but that's a separate issue))

Changing default_remote to {"origin", "upstream"} fixed this issue (by giving a nice select for which remote to use) but then I can't list issues/PRs for upstream.

Describe what you expected to happen

Either correctly assume target remote (i.e. upstream over origin), or take target remote as argument (e.g. :Octo pr create upstream), or always ask for target remote (IMO best solution)

Anything else we need to know?

Overall great plugin, thanks for your work!