pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.28k stars 125 forks source link

[Bug] Viewing diff after adding a comment in PR review breaks and throw an error #340

Open iabdelkareem opened 1 year ago

iabdelkareem commented 1 year ago

Issue Description

bug report

Describe what happened (or what feature you want)

The diff-view throw an error and breaks after adding a comment in the PR review. Please check the screen recording below and the attached error log.

https://vimeo.com/761778020

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

  1. Start reviewing a PR
  2. Navigate to a diff and add a comment ca
  3. Save the comment :update!
  4. Navigate back to the diff l
  5. An error is thrown and the diff is not displayed again

Tell us your environment

OS Fedora Linux 36 (Workstation Edition)
NVIM v0.8.0
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Anything else we need to know?

Error Log

Error detected while processing CursorMoved Autocommands for "*":
Error executing lua callback: ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276: Error executing lua: ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:277: Vim(append):Error executing lua callback: /usr/share/nvim/runtime/filetype.lua:22: Error executing lua: /usr/share/nvim/runtime/filetype.lua:23: Vim(append):Error executing lua callback: vim/keymap.lua:0: E31: No such mapping
stack traceback:
    [C]: in function 'nvim_buf_del_keymap'
    vim/keymap.lua: in function 'del'
    ...r-textobjects/lua/nvim-treesitter/textobjects/attach.lua:57: in function 'detach'
    ...er/start/nvim-treesitter/lua/nvim-treesitter/configs.lua:490: in function 'detach_module'
    ...er/start/nvim-treesitter/lua/nvim-treesitter/configs.lua:499: in function 'reattach_module'
    ...er/start/nvim-treesitter/lua/nvim-treesitter/configs.lua:108: in function <...er/start/nvim-treesitter/lua/nvim-treesitter/configs.lua:107>
    [C]: in function 'nvim_cmd'
    /usr/share/nvim/runtime/filetype.lua:23: in function </usr/share/nvim/runtime/filetype.lua:22>
    [C]: in function 'nvim_buf_call'
    /usr/share/nvim/runtime/filetype.lua:22: in function </usr/share/nvim/runtime/filetype.lua:11>
    [C]: in function 'cmd'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:277: in function <...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276>
    [C]: in function 'nvim_buf_call'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276: in function 'show_diff'
    ...k/packer/opt/octo.nvim/lua/octo/reviews/thread-panel.lua:87: in function 'show_review_threads'
    ...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:42: in function <...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:41>
stack traceback:
    [C]: in function 'nvim_cmd'
    /usr/share/nvim/runtime/filetype.lua:23: in function </usr/share/nvim/runtime/filetype.lua:22>
    [C]: in function 'nvim_buf_call'
    /usr/share/nvim/runtime/filetype.lua:22: in function </usr/share/nvim/runtime/filetype.lua:11>
    [C]: in function 'cmd'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:277: in function <...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276>
    [C]: in function 'nvim_buf_call'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276: in function 'show_diff'
    ...k/packer/opt/octo.nvim/lua/octo/reviews/thread-panel.lua:87: in function 'show_review_threads'
    ...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:42: in function <...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:41>
stack traceback:
    [C]: in function 'nvim_buf_call'
    /usr/share/nvim/runtime/filetype.lua:22: in function </usr/share/nvim/runtime/filetype.lua:11>
    [C]: in function 'cmd'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:277: in function <...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276>
    [C]: in function 'nvim_buf_call'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276: in function 'show_diff'
    ...k/packer/opt/octo.nvim/lua/octo/reviews/thread-panel.lua:87: in function 'show_review_threads'
    ...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:42: in function <...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:41>
stack traceback:
    [C]: in function 'cmd'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:277: in function <...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276>
    [C]: in function 'nvim_buf_call'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276: in function 'show_diff'
    ...k/packer/opt/octo.nvim/lua/octo/reviews/thread-panel.lua:87: in function 'show_review_threads'
    ...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:42: in function <...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:41>
stack traceback:
    [C]: in function 'nvim_buf_call'
    ...ack/packer/opt/octo.nvim/lua/octo/reviews/file-entry.lua:276: in function 'show_diff'
    ...k/packer/opt/octo.nvim/lua/octo/reviews/thread-panel.lua:87: in function 'show_review_threads'
    ...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:42: in function <...vim/site/pack/packer/opt/octo.nvim/lua/octo/autocmds.lua:41>
Executing CursorMoved Autocommands for "*"
autocommand call quick_scope#HighlightLineDelay(2, g:qs_accepted_chars)