search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.28k stars 125 forks source link

Cannot open PR #342

Closed meatballs closed 1 year ago

meatballs commented 1 year ago

Cannot open PR

Type: bug report

Describe what happened (or what feature you want)

Running Octo pr list brings up a list in telescope but, when I select a PR, I get an error:

Error executing vim.schedule lua callback: ...nvim/site/pack/packer/start/octo.nvim/lua/octo/utils.lua:1164: attempt to perform arithmetic on local 'right_side_line' (a nil value)          
stack traceback:                                                                                                                                                                             
        ...nvim/site/pack/packer/start/octo.nvim/lua/octo/utils.lua:1164: in function 'generate_position2line_map'                                                                           
        ...site/pack/packer/start/octo.nvim/lua/octo/ui/writers.lua:678: in function 'write_thread_snippet'                                                                                  
        ...site/pack/packer/start/octo.nvim/lua/octo/ui/writers.lua:1312: in function 'write_threads'                                                                                        
        ...ck/packer/start/octo.nvim/lua/octo/model/octo-buffer.lua:171: in function 'render_issue'                                                                                          
        .../nvim/site/pack/packer/start/octo.nvim/lua/octo/init.lua:253: in function 'create_buffer'                                                                                         
        .../nvim/site/pack/packer/start/octo.nvim/lua/octo/init.lua:82: in function 'cb'                                                                                                     
        .../nvim/site/pack/packer/start/octo.nvim/lua/octo/init.lua:107: in function 'cb'                                                                                                    
        ...im/site/pack/packer/start/octo.nvim/lua/octo/gh/init.lua:90: in function ''                                                                                                       
        vim/_editor.lua: in function <vim/_editor.lua:0>

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

  1. :Octo pr list
  2. Select pr from telescope list

Tell us your environment

Ubuntu 22.04 Neovim 0.8.0

pwntester commented 1 year ago

Cant reproduce, does it happen with all PRs? Can you share a project/PR you have this issue with?

meatballs commented 1 year ago

Sorry I've ignored this. I'll try again this week and report back...

meatballs commented 1 year ago

Creative procrastination appears to have struck. I updated everything and it's all working fine now.