pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.28k stars 125 forks source link

Fix the floating window size calculation #348

Closed yen3 closed 1 year ago

yen3 commented 1 year ago

If the number of max lines >= 1, it calculates a float number. It could apply to vim.api.nvim_open_win. Add the converting action to make sure the final result type is int.

Describe what this PR does / why we need it

Pass the size with correct type to create floating window.

Does this pull request fix one issue?

NONE

Describe how you did it

The result of the value may not be an integer, add the convert to make sure it's integer type.

Describe how to verify it

I verify in my local environment with :Octo pr checks

Special notes for reviews

pwntester commented 1 year ago

Thanks!