search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.28k stars 125 forks source link

Allow opening file in context of reviewed branch in Review mode #350

Closed marcomayer closed 1 year ago

marcomayer commented 1 year ago

Issue Description

Type: feature request

Describe what happened (or what feature you want)

Quite often when doing code reviews I'd like to open the file in the context of the reviewed branch in a new tab to jump around in code (goto def/ref etc). Currently, I do this by checking out the branch manually and then opening the PR.

It would be awesome if there was a command that opens the file in the tmp folder where the branch is checkout out as the workdir in a new tab.

pwntester commented 1 year ago

Hi, Will this work for you? https://github.com/pwntester/octo.nvim/pull/349

marcomayer commented 1 year ago

@pwntester yes that looks good! 🚀

pwntester commented 1 year ago

Nice, hopefully it will get merged soon. If you are not using commit-level reviews, the PR should be working for you