search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.28k stars 125 forks source link

feature: review_diff go to file #372

Closed antosha417 closed 1 year ago

antosha417 commented 1 year ago

Describe what this PR does / why we need it

This PR adds support for go_to_file in review_diff.

Often during the review I want to harness the power of lsp and see some type info, or go to definition. Currently lsp in not attached to buffers during review. But I want to be able to go_to_file to be able to use it.

Also found this comment while browsing thought the project. https://github.com/antosha417/octo.nvim/blob/92b982d7e2271597accfb3a6157a9f5efc185b24/lua/octo/reviews/file-entry.lua#L394-L400

Does this pull request fix one issue?

Fixes https://github.com/pwntester/octo.nvim/issues/371

Describe how to verify it

with default config press gf while in review_diff

Special notes for reviews

Thank you a lot for maintaining this plugin and doing neovim community better ❤️

pwntester commented 1 year ago

Thanks for the contribution! FWIW, you can also try https://github.com/pwntester/octo.nvim/pull/349 to use your local files in the diff

antosha417 commented 1 year ago

Thank you. I'll definitely check out #349 sounds really interesting!