Closed delphinus closed 1 year ago
I noticed the logic cannot ignore the latter issue combining the former one, such as #123#234
. I arrange such cases GitHub can detect in a table.
line | can detect #234? |
---|---|
#123, #234 |
can |
#123,#234 |
can |
#123#234 |
cannot |
#123_#234 |
cannot |
#123 and#234 |
cannot |
So it seems GitHub detects issues with a regex [^%w%d]+#(\d+)
. I fixed up the logic with such strategy: 01fa6e0.
Thanks for the contributions!
Describe what this PR does / why we need it
I noticed both
goto_issue
andon_cursor_hold
do not work with the latter issue when multi issues on one line.This PR solves this and slight bugs below.
#12
on the begging.Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Run
goto_issue
andon_cursor_hold
for each line and each issue/PR.Short issue pattern: #393, #394, #395 Long issue pattern: pwntester/octo.nvim#393, pwntester/octo.nvim#394, pwntester/octo.nvim#395 URL issue pattern: https://github.com/pwntester/octo.nvim/pull/393, https://github.com/pwntester/octo.nvim/pull/394, https://github.com/pwntester/octo.nvim/pull/395
Special notes for reviews