search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.25k stars 124 forks source link

Octo `comment delete` closes the window #398

Closed ribelo closed 10 months ago

ribelo commented 1 year ago

Issue Description

Octo comment delete closes diff window

Type: bug report

Describe what happened (or what feature you want)

This basically prevents further work on the review.

Describe what you expected to happen

Removing the comment doesn't close the window and doesn't prevent continuing the review.

How to reproduce it (as minimally and precisely as possible)

  1. Create a review comment <C-a>
  2. Delete a review comment <C-d>
pleicht commented 11 months ago

I also have this issue.

For additional clarity. When you delete a comment from the left pane, the buffer stops being a diff view and turns into just a split view of the file you were reviewing in the PR.

Subsequent commands that are attempted to run return Cannot find diff window (which kinda makes sense given the above bug caused the diff view to exit following a comment being deleted)

pwntester commented 10 months ago

Sorry for the late, late response. Let me know if the issue is fixed on your side